-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update quick start doc for user assigned identity #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karataliu
force-pushed
the
patch-1
branch
2 times, most recently
from
January 10, 2023 10:18
1e4b1ab
to
6cb212b
Compare
/azp run Azure Workload Identity CI |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
aramase
reviewed
Jan 10, 2023
docs/book/src/quick-start.md
Outdated
az keyvault set-policy --name "${KEYVAULT_NAME}" \ | ||
--secret-permissions get \ | ||
--spn "${USER_ASSIGNED_IDENTITY_CLIENT_ID}" | ||
--object-id "${USER_ASSIGNED_IDENTITY_CLIENT_ID}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
--object-id "${USER_ASSIGNED_IDENTITY_CLIENT_ID}" | |
--object-id "${USER_ASSIGNED_IDENTITY_OBJECT_ID}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. updated. it's interesting that previous one can also wrok.
aramase
changed the title
[DOC] Update quick start doc for user assigned identity
docs: Update quick start doc for user assigned identity
Jan 10, 2023
aramase
approved these changes
Jan 11, 2023
Previous code will return `Unable to get object id from principal name.`
/azp run Azure Workload Identity CI |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code will return
Unable to get object id from principal name.
Reason for Change:
Using
--spn
only works after a period of time ~60s, using--object-id
works immediately.Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: