Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove arc wiring and drop --arc-cluster flag from webhook #723

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 26, 2023

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • Removes the arc wiring that's in the webhook as it's unsed
  • Drops --arc-cluster flag in the webhook
  • Update manifests to remove the flags
  • Remove arc related tests

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase changed the title chore: remove arc wiring and drop --arc-cluster flag from webhook chore: remove arc wiring and drop --arc-cluster flag from webhook Jan 26, 2023
@aramase aramase marked this pull request as ready for review January 26, 2023 21:26
@aramase aramase requested a review from enj January 26, 2023 21:26
@aramase aramase enabled auto-merge (squash) January 26, 2023 22:57
@aramase aramase merged commit 216db84 into Azure:main Jan 27, 2023
@aramase aramase deleted the remove-arc-wiring branch January 27, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants