Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: documentation website backbone #82

Merged
merged 2 commits into from
Jul 12, 2021
Merged

docs: documentation website backbone #82

merged 2 commits into from
Jul 12, 2021

Conversation

chewong
Copy link
Contributor

@chewong chewong commented Jul 6, 2021

Signed-off-by: Ernest Wong [email protected]

ref: #79

@chewong chewong requested a review from sozercan July 7, 2021 22:33
@chewong chewong marked this pull request as ready for review July 7, 2021 22:33
@chewong
Copy link
Contributor Author

chewong commented Jul 7, 2021

Preview: https://deploy-preview-82--aad-pod-managed-identity.netlify.app/

@chewong chewong requested a review from aramase July 7, 2021 23:44
aramase
aramase reviewed Jul 12, 2021
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good!

The docs will be available publicly after this change is merged. @sozercan Do we want to publish the docs publicly now or when we open source it?

@chewong
Copy link
Contributor Author

chewong commented Jul 12, 2021 •
edited
Loading

GitHub Pages can be private:

image

but netlify preview is not private (needs a paid subscription).

aramase
aramase approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chewong chewong enabled auto-merge (squash) July 12, 2021 19:33
@chewong chewong merged commit 97dff5a into Azure:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase approved these changes

@sozercan sozercan Awaiting requested review from sozercan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chewong @aramase