Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add helm installation and upgrade as part of e2e #90

Merged
merged 1 commit into from
Jul 13, 2021
Merged

test: add helm installation and upgrade as part of e2e #90

merged 1 commit into from
Jul 13, 2021

Conversation

chewong
Copy link
Contributor

@chewong chewong commented Jul 9, 2021

Signed-off-by: Ernest Wong [email protected]

Reason for Change:

This PR adds helm installation and upgrade as part of our e2e.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Fixes #77

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@chewong chewong closed this Jul 12, 2021
@chewong chewong reopened this Jul 12, 2021
@chewong chewong marked this pull request as ready for review July 12, 2021 21:22
@chewong chewong requested review from aramase and sozercan July 12, 2021 21:57
Makefile Outdated Show resolved Hide resolved
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@chewong chewong requested review from sozercan and aramase July 13, 2021 17:27
@chewong chewong enabled auto-merge (squash) July 13, 2021 17:42
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chewong chewong merged commit 4569f63 into Azure:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tests for helm chart
3 participants