Fetch OIDC token in the background process to avoid expiration issue #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for assets-test18 tests 18 ✅ 33m 18s ⏱️ Results for commit 2bf0310. ♻️ This comment has been updated with latest results. |
This reverts commit 1367d1f.
iamrk04
changed the title
This reverts commit 3336fe4.
elesel
reviewed
Apr 12, 2024
elesel
reviewed
Apr 12, 2024
iamrk04
changed the title
elesel
approved these changes
Apr 12, 2024
elesel
pushed a commit
that referenced
this pull request
Apr 23, 2024
* acquire access token before expiry * temp change to trigger test * add requested url * print the current time as well * update when to get token * Revert "temp change to trigger test" This reverts commit b9dc55da738e07b24a03629188e4f17f3f9df409. * prevent logging token * temp bump version to trigger test * Revert "prevent logging token" This reverts commit 7872d09ae087689f7d8e0a45b99a329c18b08a7d. * try switching to resource * try fetching OID token every 4 mins * Revert "temp bump version to trigger test" This reverts commit dd27330d9c71e940fbef147155cfc5d00963f9c5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OID token expires after 5 mins and hence all of our test fails with the following error:
I propose to fix this by fetching this token every 4 mins. For more details on the issue, please check this issue.