Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for bicep files in VS Code #521

Closed
anwather opened this issue Sep 18, 2020 · 10 comments · Fixed by microsoft/vscode#119468
Closed

Icon for bicep files in VS Code #521

anwather opened this issue Sep 18, 2020 · 10 comments · Fixed by microsoft/vscode#119468
Labels
enhancement New feature or request

Comments

@anwather
Copy link

Is your feature request related to a problem? Please describe.
Add an icon (probably haven't got one yet ;) ) to the vs code extension

Describe the solution you'd like
Currently getting the txt file icon - would be nice to have a proper icon

@anwather anwather added the enhancement New feature or request label Sep 18, 2020
@ghost ghost added the Needs: Triage 🔍 label Sep 18, 2020
@majastrz
Copy link
Member

Good idea!

@anwather
Copy link
Author

Added #542

@JustinGrote
Copy link

FYI there is a new API in insiders for this, this is what you should use.
microsoft/vscode#114942 (comment)

@anthony-c-martin
Copy link
Member

@JustinGrote - looks like that API allows you to define custom icons in an extension, but not register them as file icons (only for use in other places). It seems like we're close though - there's discussion in this issue about implementing exactly what we need: microsoft/vscode#14662

@JustinGrote
Copy link

@anthony-c-martin whoops my bad, yes the groundwork is there but the actual implementation for extensions is not, looks like he's gonna work on it though:
microsoft/vscode#14662 (comment)

@JustinGrote
Copy link

And FYI I've been using vscode-icons as a workaround. I've submitted it as an issue there.
vscode-icons/vscode-icons#2712

@anthony-c-martin
Copy link
Member

This the icon we're planning to use for VSCode file icons: https://github.com/jesseweed/seti-ui/blob/b6e2289830ea77271c76fb8e0d02319f16a1c0d7/icons/bicep.svg

@JustinGrote
Copy link

FYI it is now part of vscode-icons
vscode-icons/vscode-icons#2715

@anthony-c-martin
Copy link
Member

FYI my change to add the .bicep icon has been merged: jesseweed/seti-ui@b6e2289, so I expect this'll be picked up in the next major VSCode release.

@anthony-c-martin
Copy link
Member

This has since been rolled out with VSCode.

@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
5 participants