Adding some file icons to the vs code extension

[anwather]

fixes #521
Added light and dark icons

[alex-frankel]

thank you @anwather for picking this up!

We have a few concerns about what icon assets we are allowed to use, so we'd prefer to work with our design team to get those assets generated. We also would prefer them to be SVGs if possible. Would you be alright if we provide you the assets, and then you can use those and update the PR?

[anwather]

@alex-frankel Not a problem - thought that might be a concern but the groundwork is there 👍

[kilasuit]

incase you didn't know if you edit this comment and add

fixes #521 it will properly link that this PR should fix that issue & close it

this is how it looks in the issue (which is really helpful)

but more helpful it shows in the Issue list like this which helps people not raise multiple PR's against the same Issue

[alex-frankel]

We mocked up a few potential options for this, curious to hear what folks think about these:

mechanical arm:

lowercase "b":

[kilasuit]

+1 for Mechanical ARM

[anwather]

I think I like the 'b' - but maybe raise an issue and pin it to get people to vote 👍

[anthony-c-martin]

I dug a bit further into this, and it seems that the contribution point you're using in this PR ("iconThemes") is intended for a theming extension to provide a full set of icons to replace all file types in VSCode. So while this results in the bicep icon being assigned to .bicep files, it removes icons from all other files.

From my understanding, the correct way to get icons into VSCode is to contribute to the setui repo, which generates an iconfont that is periodically rolled into the main VSCode build. I've submitted a PR to add a .bicep icon here: jesseweed/seti-ui#586.

As such I'm going to close this PR as I don't think it's the correct approach, but please feel free to reopen if I'm missing something!

[anwather]

Thanks @anthony-c-martin - tbh I haven't done it before :)