[Bug]: DAB shouldn't throw exceptions for scenarios that are ONLY applicable to file based configs #1820
Closed
1 task done
Comments
aaronpowell
added a commit
that referenced
this issue
Oct 18, 2023
Test isn't implementing logic of #1820 yet, just replicating an existing test to ensure the test runner passes initially. Created in a new test class to reduce changes of merge conflicts, but extracted out shared logic from existing test class.
aaronpowell
added a commit
that referenced
this issue
Oct 18, 2023
2 tasks
2 tasks
Aniruddh25
pushed a commit
that referenced
this issue
Oct 21, 2023
…1825) (#1834) Cherry pick #1825 to 0.9 ## Why make this change? - Fixes #1820 ## What is this change? - New test coverage for #1820 - Added a way to control error handling when env vars aren't set - default is left to throw, override to ignore ## How was this tested? - [x] Integration Tests - [ ] Unit Tests Co-authored-by: Aaron Powell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Exceptions thrown while parsing configuration for example:
data-api-builder/src/Config/Converters/StringJsonConverterFactory.cs
Line 79 in 038c17d
should only be thrown when the configuration is sourced from a file.
For configurations provided to the configuration endpoint - these exceptions should NOT be thrown.
This issue to track down such exceptions that are ONLY applicable to file based configuration and disable throwing them for non-file based configs.
E.g. Exception
Version
0.8.52
What database are you using?
Azure SQL
What hosting model are you using?
Static Web Apps (SWA)
Which API approach are you accessing DAB through?
GraphQL
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: