-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-Memory Cache #1881
In-Memory Cache #1881
Conversation
… dev/seantleonard/inmemorycache
…zure/data-api-builder into dev/seantleonard/inmemorycache
… path. ran dotnet format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, posting comments so far, tests remaining..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very Comprehensive tests, left some questions.
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat. Good usage of mocks for writing the integration tests.
Few nits, otherwise, LGTM!
…ache or entity cache settings). Updates appsettings json file with feature flag defaulted to false. added feature flag class with constant.
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Addressed comments and received additional reviews.
Azure Pipelines successfully started running 6 pipeline(s). |
Why make this change?
What is this change?
DabCacheService
which is used in database queries (REST/GraphQL) such that requests and responses are cached in memory.SqlQueryEngine.ExecuteAsync(...)
such that thecacheEntryTtl
andcacheEnabled
values are resolved from runtime config and used determine whether to use the cache and how to use the cache.How was this tested?
Sample Request(s)
Until all related PRs are merged, this feature is gated by a feature flag. To add the feature flag, add the following snippet to the
AppConfig.json
:Point requests will be cached with a default 10 second ttl. You can try out whether response times are quicker for your use case.