Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain Default Data Source Name from Original Config after Hot Reloading #2069

Merged
merged 23 commits into from
Mar 13, 2024
Merged

Maintain Default Data Source Name from Original Config after Hot Reloading #2069

merged 23 commits into from
Mar 13, 2024

Commits on Feb 28, 2024

  1. pass in datasource to save in hot reload

    @aaronburtle
    aaronburtle committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    899bd9d View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. add helper to update dictionaries in runtimeconfig

    @aaronburtle
    aaronburtle committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7b1bfc4 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. add testing, cleanup format

    @aaronburtle
    aaronburtle committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    efd04ba View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. addressing comments, still need to remove GetDataSourceName()

    @aaronburtle
    aaronburtle committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    ecac30f View commit details
    Browse the repository at this point in the history

  2. remove un-needed function for getting dataSourceName, cleanup test st… 

    …ructure
    @aaronburtle
    aaronburtle committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    2f57773 View commit details
    Browse the repository at this point in the history

  3. whitespace

    @aaronburtle
    aaronburtle committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    58d418c View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. clarifying comments

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    732d32e View commit details
    Browse the repository at this point in the history

  2. refactor update

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    81b2ecd View commit details
    Browse the repository at this point in the history

  3. use private DefaultDataSourceName

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    b3c067b View commit details
    Browse the repository at this point in the history

  4. typos

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    873445a View commit details
    Browse the repository at this point in the history

  5. push change to rivate

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    1a9229d View commit details
    Browse the repository at this point in the history

  6. match mocked loader to new signature

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    da0abcd View commit details
    Browse the repository at this point in the history

  7. change get method to property

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f16ef6d View commit details
    Browse the repository at this point in the history

  8. update references to property

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5e1b057 View commit details
    Browse the repository at this point in the history

  9. add ignore for default data source name to unit test verifier

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    579199f View commit details
    Browse the repository at this point in the history

  10. style fix

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    be78615 View commit details
    Browse the repository at this point in the history

  11. merging

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    3d31d89 View commit details
    Browse the repository at this point in the history

  12. merging main

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    7f316c3 View commit details
    Browse the repository at this point in the history

  13. add ignore for other tests in verifier for Jsonignored DefaultDatasou… 

    …rceName
    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9d1bd74 View commit details
    Browse the repository at this point in the history

  14. defensive coding, typo fix

    @aaronburtle
    aaronburtle committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f295edb View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. format

    @aaronburtle
    aaronburtle committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5148832 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dev/aaronburtle/SaveDataSourceNameForHotReload

    @aaronburtle
    aaronburtle authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    be7bd5e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into dev/aaronburtle/SaveDataSourceNameForHotReload

    @aaronburtle
    aaronburtle authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    937b731 View commit details
    Browse the repository at this point in the history