Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Fix: Adding Github Pat Token for Private Repo Installation #365

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

brnleehng
Copy link
Collaborator

Copy link

@bgklein bgklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some nits but otherwise looks fine

if (githubAuthenticationToken != "") {
installCommand <-
paste(installCommand,
sprintf("-e \'githubAuthToken <- \\\"%s\\\"\'", githubAuthenticationToken),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need a space before -e?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single quote ' strings to avoid needing to escape stuff?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. paste command adds a space automatically. paste0 would require me to have a space before -e
  2. Single quote for escaping stuff.

@brnleehng brnleehng merged commit d206fd6 into master Aug 13, 2019
@brnleehng brnleehng deleted the fix/github-pat-token branch August 13, 2019 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants