Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format #18

Closed
wants to merge 1 commit into from

Conversation

konrad-jamrozik
Copy link

Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format.

This discussion explains why we chose given vmImage format:

Mike Harder: 1ES Hosted Pool image name changes
posted in Azure SDK / Engineering System 🛠️ at Wednesday, February 15, 2023 12:10 PM

Changes made in the PR

  • search-and-replace all occurrences of windows-2019 and windows2019 to corresponding 2022 variant
  • search-and-replace azsdk-pool-mms-win-2019-general with azsdk-pool-mms-win-2022-general
  • added azsdk-pool-mms-win-2022-general as pool name to docindex.yml files, as it was absent from there
  • search and replace MMS2019 and MMS2022 to windows-2022

Context

For further context, please see:

@konrad-jamrozik
Copy link
Author

@benbp @mikeharder need an approval on this one. Albeit because the changelog is large, it probably should be reviewed by a subject matter expert.

@konrad-jamrozik
Copy link
Author

Closing this PR. Per my chat with @mikeharder, this PR is not necessary, as the files having the obsolete pool that needs to be updated are not actually used anywhere; they are just copied over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant