Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scheduled triggers in pipelines #6458

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

damonbarry
Copy link
Member

@damonbarry damonbarry commented Jun 17, 2022

This change makes several updates to schedule triggers in various pipelines to bring them up to date and make them more consistent with one another:

  • Update triggers to target release/1.3 instead of release/1.2. Note that, given how schedule triggers work in Azure pipelines, these changes in main won't actually impact the schedules in release/1.2 or release/1.3. To do that, we'll need to make changes in the respective branches. Disabled scheduled autorun for test pipelines #6453 covers release/1.2, and I'll merge this change into release/1.3 as well.
  • In cases where schedule triggers are found in other branches besides main for a given pipeline, bring those changes into main for consistency. Again, this doesn't actually change how the schedule triggers will work, it simply brings all the information together into one place.
  • In nested-e2e.yaml, restore time offsets to "0 0 ..." and "0 12 ..." for consistency with other pipelines, since it no longer shares test agents with the recently removed nested connectivity pipeline.
  • In upgrade-scenarios.yaml, fix a problem where the schedule trigger was only firing for main. We want it to fire for the release branches as well.
  • In service-deployment.yaml, update the schedule trigger to be consistent with how it's defined in release/1.1.
  • Remove trailing whitespace as needed.

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

@damonbarry damonbarry requested review from huguesBouvier, and-rewsmith, nlcamp and yophilav and removed request for and-rewsmith June 17, 2022 22:11
@@ -1,5 +1,12 @@
trigger: none
pr: none
schedules:
- cron: "0 23 * * 4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this nested longhaul pipeline doesn't share the same agents as the single-node longhaul, so it's ok to use the same schedule?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. This is the schedule we're already using today, I just copied it to the main branch as well.

Copy link
Contributor

@nlcamp nlcamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

This reminded me of another change we'll need to make when we create the release/1.3 branch. I've created a PBI to address it titled "Change 'main' to 'release/1.3' in upgrade scenarios pipeline on release/1.1 branch"

@kodiakhq kodiakhq bot merged commit 1447efe into Azure:main Jun 20, 2022
@damonbarry damonbarry deleted the update-schedules branch June 20, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants