Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.3] Do not rename configuration items for SystemInfo #6463

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

onalante-msft
Copy link
Contributor

This was an oversight when forward-porting from release/1.2; configuration items for additional information are no longer renamed during merging.

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

Oversight when forward-porting from release/1.2.
Copy link
Contributor

@lfitchett lfitchett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 4c4717e into Azure:main Jun 22, 2022
@onalante-msft onalante-msft deleted the systeminfo-no-rename-1.3 branch June 22, 2022 17:59
micahl pushed a commit to micahl/iotedge that referenced this pull request Jul 8, 2022
…#6463)

This was an oversight when forward-porting from release/1.2; configuration items for additional information are no longer renamed during merging.

## Azure IoT Edge PR checklist:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants