Make iotedge check respect journald as valid log rotation setting. #6734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsing
requested changes
Oct 27, 2022
mtrensch
force-pushed
the
feature/iotedge-check-journald
branch
from
8ac2292
to
5a95701
Compare
arsing
approved these changes
Oct 28, 2022
gordonwang0
approved these changes
Oct 28, 2022
nlcamp
pushed a commit
to nlcamp/iotedge
that referenced
this pull request
Nov 1, 2022
…zure#6734) This PR will make iotedge check respect docker's journald logdriver as a valid log rotation setting. See issue Azure#6728 ## Azure IoT Edge PR checklist:
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make iotedge check respect docker's journald logdriver as a valid log rotation setting.
See issue #6728
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines
Draft PRs
Draftmode if it is:Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description