iotedge check: Only verify logging options for json-file driver #6793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrensch
force-pushed
the
iotedge-check-logrotate
branch
2 times, most recently
from
993f724
to
f0da82d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
mtrensch
force-pushed
the
iotedge-check-logrotate
branch
from
f0da82d
to
23d02b0
Compare
arsing
requested changes
Nov 28, 2022
mtrensch
force-pushed
the
iotedge-check-logrotate
branch
from
23d02b0
to
3f1c752
Compare
…h is the default). This fixes Azure#6754 NOTE: All other logging driver usually do logrotation on their own
mtrensch
force-pushed
the
iotedge-check-logrotate
branch
from
3f1c752
to
2071f48
Compare
arsing
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All logging drivers, except json-file (which is the default) do log rotation on their own.
See https://docs.docker.com/config/containers/logging/configure/
This fixes #6754
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines
Draft PRs
Draftmode if it is:Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description