Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics-collector - split D2C messages greater than limit #6904

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

LiamDavey
Copy link

@LiamDavey LiamDavey commented Feb 13, 2023

We currently use metrics-collector configured with environment variable IoTMessage to send metrics as D2C messages upstream to IoT Hub. The current version of metrics-collector does not split D2C messages, even if they are greater than the D2C message limit (256KB). This results in us currently getting a MessageTooLargeException when trying to scrape our custom modules in addition to edgeHub and edgeAgent. This PR adds functionality to split D2C messages before sending upstream if messages are greater than limit.

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

@LiamDavey
Copy link
Author

@microsoft-github-policy-service agree

@vasdee
Copy link

vasdee commented May 10, 2023

Any chance this could be reviewed and merged? It's a very handy feature and we are currently having to run patched versions of this in order to work around the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants