Supporting Multiple Files With the Same Name #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…since failing annotations shouldn't affect users
This reverts commit 8da79a8.
…ivate to use filepath relative to tmp dir
davidgamero
reviewed
Aug 6, 2024
davidgamero
approved these changes
Aug 6, 2024
OliverMKing
reviewed
Aug 6, 2024
OliverMKing
reviewed
Aug 6, 2024
OliverMKing
reviewed
Aug 6, 2024
OliverMKing
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #315
Plus cleaning up how we organize files for private cluster deployment and cleaning up various file-related operations.
Added unit tests for this in manifestUpdateUtils.test.ts and modified basic integration tests to test for this scenario as well.