test(e2e): add git_ref for manual trigger to allow testing on branches #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TestingOnBranches
tallaxes
approved these changes
Nov 16, 2023
charliedmcb
deleted the
charliedmcb/addGITREFForManualTriggerToAllowTestingOnBranches
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Triggering the
E2EMatrixTriggerworkflow for a non-main branch doesn't actually end up testing on the non-main branch. Instead it ends up still testing the main branch.This is particularly an issue when someone is updating the e2e test matrix. We want to allow devs to test their changes to the e2e matrix before checking it in.
By making the resolve args special case for manual triggers and grab the branch name this should allow for devs to manually trigger the workflows for their changes and get them tested before checking in.
How was this change tested?
Manually ran an E2E test on this branch:
https://github.com/Azure/karpenter/actions/runs/6882110677
Note: at the time I added an additional fake E2E test suite to the matrix called
Anotherjust to ensure things were being picked up correctly.Also, note that confirming the git_ref on this run matches the correct commit.
*
Does this change impact docs?
Release Note