Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop nodeclaim webhook operation DELETE and bump karpenter-core #30

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Nov 13, 2023

Description

This change drops the webhook verb DELETE from NodeClaims and bumps karpenter-core to the version that includes kubernetes-sigs/karpenter#772

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes changed the title fix: drop nodeclaim webhook operation DELETE fix: drop nodeclaim webhook operation DELETE and bump karpenter-core Nov 13, 2023
@tallaxes tallaxes marked this pull request as ready for review November 13, 2023 05:22
@comtalyst
Copy link
Collaborator

lgtm

Copy link
Collaborator Author

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

Copy link
Collaborator Author

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@tallaxes tallaxes merged commit e983049 into main Nov 15, 2023
12 checks passed
@tallaxes tallaxes deleted the tallaxes/webhook-delete branch November 15, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants