Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remaining e2e unit test cases #33

Merged
merged 11 commits into from
Dec 22, 2023
Merged

test: remaining e2e unit test cases #33

merged 11 commits into from
Dec 22, 2023

Conversation

rakechill
Copy link
Contributor

@rakechill rakechill commented Nov 14, 2023 •
edited
Loading

Description

  • Ensure launch template provider sets tags in ARM-compatible format
  • Update garbage collection tests to be based on pod pressure
  • Will follow-up with a second PR that may remove linking. As such, going to not update linking test suite for now. chore: remove all references to linking #48

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

@rakechill rakechill changed the title test: remaining e2e unit test cases (minus spot capacity tests) test: remaining e2e unit test cases Nov 14, 2023
@rakechill rakechill marked this pull request as ready for review November 16, 2023 17:46
rakechill
rakechill commented Dec 20, 2023
View reviewed changes
Copy link
Contributor Author

@rakechill rakechill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

rakechill
rakechill commented Dec 21, 2023
View reviewed changes
Copy link
Contributor Author

@rakechill rakechill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@rakechill rakechill merged commit 0bcd77d into main Dec 22, 2023
8 checks passed
@rakechill rakechill deleted the rakechill/remaining-e2e-unit-tests branch December 22, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian approved these changes

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakechill @Bryce-Soghigian