fix: support non-zonal regions #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rakechill
reviewed
Nov 28, 2023
Bryce-Soghigian
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
E2E Tests pass, ran tests locally and zonal behavior seems to behave as we expect.
There is a bit of concern about the hardcoded regions. Basically for each new azure region we will need to bump this list. But thats true as well for our image gallery, and we will have a clear heads up when to do so.
given we follow up with an item for making this process programatic in the future, and this is certainly a step forward, lets approve and follow up with work to see if a programatic approach to getting the regions is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for non-zonal regions / VMs.
Will also correctly filter out VM SKUs with location restriction.
How was this change tested?
make presubmit, manual testing in non-zonal region (westcentralus), E2E testsDoes this change impact docs?
Release Note