Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: the output format of az command was specified #351

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

jacobbaek
Copy link
Contributor

It is better to set output format.

Fixes #

Description
someone might specify the ouput format as table or yaml.
If then, this script will fail.
So I added the output format as json.

How was this change tested?
it works well.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


It is better to set output format.
@coveralls
Copy link

coveralls commented May 14, 2024

Pull Request Test Coverage Report for Build 11486913099

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.866%

Totals Coverage Status
Change from base Build 11486809298: 0.0%
Covered Lines: 36318
Relevant Lines: 37110

💛 - Coveralls

@jacobbaek
Copy link
Contributor Author

@tallaxes
Could you review this PR?

tallaxes
tallaxes previously approved these changes Oct 23, 2024
Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution! (and apologies for the delay in reviewing)

@tallaxes tallaxes merged commit f7b6f9d into Azure:main Oct 23, 2024
11 checks passed
@jacobbaek jacobbaek deleted the patch-1 branch October 24, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants