Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): add production env to release workflow #418

Open
wants to merge 1 commit into
base: charliedmcb/automatedGithubReleasesInWorkflow
Choose a base branch
from

Conversation

charliedmcb
Copy link
Collaborator

Fixes #

Description

Using environments for deployment will allow us to put Required reviewers on the release workflows.

Note: this does require us to add a production env to the github repo. I think this approach is correct for us as we are moving towards a more automated release process. However, it does deviate from aws some.

How was this change tested?
Nothing additional
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

@coveralls
Copy link

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9700698985

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 97.758%

Files with Coverage Reduction New Missed Lines %
pkg/cache/unavailableofferings.go 2 95.45%
Totals Coverage Status
Change from base Build 9654039110: -0.006%
Covered Lines: 36285
Relevant Lines: 37117

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants