Add hugo docsy website #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess step 1 is to merge and step 2 would be to setup a netlify deployment based on our repo? |
|
@tallaxes how do you feel about letting the base docs that just copied our existing documentation go in as is minus the doc change? We need to add docs on
ETC Or do you think we should merge docs with AWS and have them in one place? Does the karpenter website code belong here? Referring to questions still to be answered here |
Signed-off-by: David Tesar <[email protected]>
Bryce-Soghigian
previously approved these changes
Dec 18, 2023
sftim
reviewed
Dec 19, 2023
Signed-off-by: David Tesar <[email protected]>
Signed-off-by: David Tesar <[email protected]>
Signed-off-by: David Tesar <[email protected]>
Signed-off-by: David Tesar <[email protected]>
|
So what are next steps once this merges in? We buy a domain? Then setup netlify to deploy based on main, as well as preview builds? |
|
@sftim thank you for your review here btw its appreciated! |
|
You can use the netlify deploy url to start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add hugo docsy website
docs: some changes to existing documentation to make it work and make sense in the website
Description
You can see what the website looks like for this code via the netlify deployment here. If desired - a more granular breakdown of commit changes on the PR I merged in my fork.
Does this change impact docs?
Release Note