You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two tests relied on checking underlying instance state (via VMClient). These will be circled back to in the future once we add support for calling Azure APIs directly via the test environment.
I'm seeing one case fail due to garbage collection. Investigating now...
{"level":"INFO","time":"2023-11-07T22:36:50.001Z","logger":"controller.nodeclaim.lifecycle","message":"launched nodeclaim","commit":"58975a5-dirty","nodeclaim":"soarerboom-19-lrvave4f6g","nodepool":"","provider-id":"azure:///subscriptions//resourceGroups/mc_karpenter-e2e-nodeclaim-rg-46813590_nodeclaim-mc-46813590_westus2/providers/Microsoft.Compute/virtualMachines/aks-soarerboom-19-lrvave4f6g","instance-type":"Standard_D2pls_v5","zone":"","capacity-type":"on-demand","allocatable":{"cpu":"1900m","ephemeral-storage":"128G","memory":"2014Mi","pods":"110"}}
{"level":"DEBUG","time":"2023-11-07T22:37:03.399Z","logger":"controller.nodeclaim.garbagecollection","message":"garbage collecting nodeclaim with no cloudprovider representation","commit":"58975a5-dirty","nodeclaim":"soarerboom-19-lrvave4f6g","provider-id":"azure:///subscriptions//resourceGroups/mc_karpenter-e2e-nodeclaim-rg-46813590_nodeclaim-mc-46813590_westus2/providers/Microsoft.Compute/virtualMachines/aks-soarerboom-19-lrvave4f6g","nodepool":""}
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Wish we could test this within the actual workflow, but your local testing should be good enough. Will mull over creating a better way of testing new E2E suites, since it can't currently be done within the workflow.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charliedmcb
requested review from
charliedmcb
and removed request for
charliedmcb
Description
How was this change tested?
make testmake az-e2etestsDoes this change impact docs?