Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning due to Node 16 #357

Closed
Piedone opened this issue Oct 24, 2023 · 27 comments · Fixed by #411
Closed

Deprecation warning due to Node 16 #357

Piedone opened this issue Oct 24, 2023 · 27 comments · Fixed by #411
Assignees
@YanaXu
Labels
dependencies Pull requests that update a dependency file product enhancement New feature or request

Comments

@Piedone
Copy link

Piedone commented Oct 24, 2023 •
edited
Loading

Node 16 is now deprecated. Because of this, when using this action, you'll see warnings.

Please update the action to Node 20.
@Piedone Piedone added the need-to-triage Requires investigation label Oct 24, 2023
@Piedone Piedone mentioned this issue Oct 24, 2023
Closed
9 tasks
@YanaXu
Copy link
Collaborator

YanaXu commented Oct 26, 2023

Thanks @Piedone . We'll add it to our plan.

@YanaXu YanaXu self-assigned this Oct 26, 2023
@YanaXu YanaXu added the dependencies Pull requests that update a dependency file label Oct 26, 2023
@Piedone
Copy link
Author

Piedone commented Oct 26, 2023

Thank you!

@YanaXu YanaXu added product enhancement New feature or request and removed need-to-triage Requires investigation labels Dec 5, 2023
@YanaXu YanaXu mentioned this issue Dec 28, 2023
Closed
@j-chao j-chao mentioned this issue Jan 23, 2024
Merged
@MoChilia MoChilia mentioned this issue Jan 26, 2024
Closed
@JosiahSiegel JosiahSiegel mentioned this issue Jan 29, 2024
Closed
@c-ryan-k c-ryan-k mentioned this issue Jan 29, 2024
Merged
7 tasks
@spkane
Copy link

spkane commented Jan 29, 2024

cc/ @manidharanupoju24 (Another action that will need updating when a new Node 20 version is released).

@vytux-com vytux-com mentioned this issue Jan 30, 2024
Closed
@eikooc eikooc mentioned this issue Jan 30, 2024
Closed
@manuelpagliuca
Copy link

A new version will be released soon or just the current will be updated?

@ViktorDronov
Copy link

ViktorDronov commented Jan 31, 2024 •
edited
Loading

also interested in this update

@erikverwer erikverwer mentioned this issue Jan 31, 2024
Closed
@arnoldknott arnoldknott mentioned this issue Feb 6, 2024
Closed
jhk-mjolner added a commit to Open-Pectus/Open-Pectus that referenced this issue Feb 7, 2024
@jhk-mjolner
Updated (most) github actions to versions using node 20
d0dda42 
Azure are a bunch of slowpokes and haven't updated theirs yet:
Azure/login#357
Azure/aci-deploy#75
@jhk-mjolner jhk-mjolner mentioned this issue Feb 7, 2024
Merged
@onionhammer
Copy link

anyone maintaining this action?

@dbelyaev
Copy link

dbelyaev commented Feb 12, 2024 •
edited
Loading

Please, prioritize this upgrade task.

This action is used by tenth of thousands of different projects, and deprecation has been announced in 09/2023.

@FlorentATo
Copy link

@YanaXu can we prioritize this ? Thank you

@tjementum
Copy link

Would be great to get this solved. 🙏

@tjementum tjementum mentioned this issue Feb 14, 2024
Merged
3 tasks
tjementum added a commit to platformplatform/PlatformPlatform that referenced this issue Feb 14, 2024
@tjementum
Upgrade GitHub actions to latest versions for Node.js compatibility (#…
e73d533 
…310)

### Summary & Motivation

All GitHub Actions used in the project are updated to their latest
versions, a move primarily motivated by the deprecation of Node.js
version 16. The updates include transitioning from:

- actions/checkout@v3 to actions/checkout@v4
- actions/download-artifact@v3 to actions/download-artifact@v4
- actions/upload-artifact@v3 to actions/upload-artifact@v4
- docker/setup-buildx-action@v2 to docker/setup-buildx-action@v3
- actions/setup-dotnet@v3 to actions/setup-dotnet@v4
- actions/setup-java@v3 to actions/setup-java@v4

However, azure/login@v1 remains unchanged as it awaits an update for
Node.js 20 compatibility, as discussed in
Azure/login#357.

### Checklist

- [x] I have added a Label to the pull-request
- [x] I have added tests, and done manual regression tests
- [x] I have updated the documentation, if necessary
@dcaro
Copy link
Collaborator

dcaro commented Feb 14, 2024

Thanks for the feedback and your patience, there are some challenges related to this that we need to solve as we address this issue. We will prioritize this work in our upcoming sprints and will report our ETA shortly.

@justinmchase
Copy link

I just want to point out that this is emitting warnings in everyones workflows...

image

@justinmchase
Copy link

...there are some challenges related to this that we need to solve...

Can you elaborate @dcaro? Because it looks like its literally as simple as changing node16 to node20 in the action.yml file. I see there are already two PR's with this code change that you could probably merge in a couple minutes. But if you could elaborate on the concerns perhaps the pepople willing to do pull requests could address those changes?

It seems like just slapping a v2 onto it could help, no?

@jpmckearin
Copy link

For anyone that needs some guidance, our team at @contessahealth has made the necessary changes and validated the deprecation warning is fixed in our own pipeline using this commit contessahealth@4ffff95. I don't recommend anyone point directly at this repository as it will potentially be deleted once the upstream is updated; however, this can at least give you some direction on how to do this in your own fork as a stopgap. You will need to build a release in the branch you target as well. It also validates @justinmchase comment above that this is an extremely simple change.

@danielmarbach danielmarbach mentioned this issue Feb 19, 2024
Merged
@jason-berk-k1x
Copy link

does anybody else see the irony in all this?

@tim-chaffin
Copy link

Ran a test this morning to confirm this. I'm still getting a warning. Do we need to flip a version number or something?

@martincostello
Copy link

Doesn't look like the tags have been updated.

@tim-chaffin
Copy link

@YanaXu - could we have those tags updated, please?

@onionhammer
Copy link

Any ETA on release?

@YanaXu
Copy link
Collaborator

YanaXu commented Feb 21, 2024

Hi @martincostello , @tlchaffi , @onionhammer , we're working on this and the PR is merged. Please wait for the release.

@ViktorDronov
Copy link

ViktorDronov commented Feb 22, 2024 •
edited
Loading

Hi @martincostello , @tlchaffi , @onionhammer , we're working on this and the PR is merged. Please wait for the release.

@YanaXu
is there any timeline for release?
It would be nice to close this issue once it's fixed, not now

@YanaXu
Copy link
Collaborator

YanaXu commented Feb 23, 2024

Hi @ViktorDronov , we're testing it offline and working on the release date. It will happen soon. Please be patient for a few more days.
We didn't close this issue manually. It's closed because the related PR is merged. The issue's closure is automatically triggered by GitHub. Please be aware of this, if an issue is closed by a PR merge, it only works after a new release.

@tim-chaffin
Copy link

Thread bump to make sure the issue doesn't go stale.

@YanaXu any update on the QA cycle, and an ETA?

@YanaXu
Copy link
Collaborator

YanaXu commented Mar 1, 2024

Hi @tim-chaffin, we'll release it next week.

@Kaibaer Kaibaer mentioned this issue Mar 5, 2024
Closed
@tim-chaffin
Copy link

Nudge @YanaXu
Its been a few weeks now. Bumping this so its not forgotten. Any ETA?

@onionhammer
Copy link

It's out

@tim-chaffin
Copy link

Good call out @onionhammer , I didn't see the new tag.

For anyone who finds this issue, the fix was released here: https://github.com/Azure/login/releases/tag/v2.0.0
Syntax: uses: azure/login@v2 to resolve.

@Piedone
Copy link
Author

Piedone commented Mar 11, 2024

Perhaps you can nudge your colleagues here? Azure/webapps-deploy#372

Smurf-Engineer pushed a commit to Smurf-Engineer/Platform that referenced this issue Apr 8, 2024
@tjementum
Upgrade GitHub actions to latest versions for Node.js compatibility (…
748634f 
…#310)

### Summary & Motivation

All GitHub Actions used in the project are updated to their latest
versions, a move primarily motivated by the deprecation of Node.js
version 16. The updates include transitioning from:

- actions/checkout@v3 to actions/checkout@v4
- actions/download-artifact@v3 to actions/download-artifact@v4
- actions/upload-artifact@v3 to actions/upload-artifact@v4
- docker/setup-buildx-action@v2 to docker/setup-buildx-action@v3
- actions/setup-dotnet@v3 to actions/setup-dotnet@v4
- actions/setup-java@v3 to actions/setup-java@v4

However, azure/login@v1 remains unchanged as it awaits an update for
Node.js 20 compatibility, as discussed in
Azure/login#357.

### Checklist

- [x] I have added a Label to the pull-request
- [x] I have added tests, and done manual regression tests
- [x] I have updated the documentation, if necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YanaXu YanaXu

Labels
dependencies Pull requests that update a dependency file product enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Action to use Node.js v20 j-chao/login