-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC support (with PS support) #157
Conversation
* OIDC support ps (#155) ps login support * Update main.ts * formatting code
@@ -15,9 +15,11 @@ export class ServicePrincipalLogin implements IAzurePowerShellSession { | |||
subscriptionId: string; | |||
resourceManagerEndpointUrl: string; | |||
allowNoSubscriptionsLogin: boolean; | |||
federatedToken:string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit formatting: space
import * as core from '@actions/core'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main.ts is difference is not showing properly. What all has changed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/main.ts
Outdated
//If few of the individual credentials (clent_id, tenat_id, subscription_id) are missing in action inputs. | ||
if (!(servicePrincipalId && tenantId && (subscriptionId || allowNoSubscriptionsLogin))) | ||
throw new Error("Few credentials are missing.ClientId,tenantId are mandatory. SubscriptionId is also mandatory if allow-no-subscriptions is not set."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: space after fullstops for error messages
This PR contains OIDC support (with PS) for login action.
Since the latest versions of packages had to be picked, node_modules are also checked in.