OIDC support (with PS support) #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OIDC support ps (#155) ps login support * Update main.ts * formatting code
kaverma
reviewed
Oct 21, 2021
| @@ -15,9 +15,11 @@ export class ServicePrincipalLogin implements IAzurePowerShellSession { | |||
| subscriptionId: string; | |||
| resourceManagerEndpointUrl: string; | |||
| allowNoSubscriptionsLogin: boolean; | |||
| federatedToken:string; | |||
kaverma
reviewed
Oct 21, 2021
| import * as core from '@actions/core'; |
There was a problem hiding this comment.
main.ts is difference is not showing properly. What all has changed here?
There was a problem hiding this comment.
Yeah, some issue is showing diff there.
You can hide whitespaces from the below settings, which will make easy to see the diff.
kaverma
reviewed
Oct 21, 2021
src/main.ts
Outdated
| //If few of the individual credentials (clent_id, tenat_id, subscription_id) are missing in action inputs. | ||
| if (!(servicePrincipalId && tenantId && (subscriptionId || allowNoSubscriptionsLogin))) | ||
| throw new Error("Few credentials are missing.ClientId,tenantId are mandatory. SubscriptionId is also mandatory if allow-no-subscriptions is not set."); |
There was a problem hiding this comment.
nit: space after fullstops for error messages
kaverma
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains OIDC support (with PS) for login action.
Since the latest versions of packages had to be picked, node_modules are also checked in.