This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
autogenerated-apimanagementapidiagnostic #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2019
Closed
This was referenced Aug 5, 2019
Closed
metacpp
suggested changes
Aug 5, 2019
list_resources.sh
Outdated
| @@ -4,7 +4,7 @@ cd `dirname $0` | |||
| for file in `ls ./specs`; do | |||
| work_dir=./specs/$file | |||
| if [ -d $work_dir ]; then | |||
| if [ -n "$(git status -s $work_dir)" ]; | |||
| if [ -n "$(git diff --name-only remotes/origin/master remotes/origin/$source_branch -- $work_dir)" ]; | |||
There was a problem hiding this comment.
What if we need to run it in local environment ? Can we add a fallback logic ?
There was a problem hiding this comment.
Add the fallback logic in script.
- We can run
make build SOURCE_BRANCH=branchname, to generate codes for new added/modified resources in local branch - If
SOURCE_BRANCHis not set, it uses current branch as default, and generates codes for new added/modified resources in current branch - For uncommitted changes, just uses
make build RESOURCE=resourcenameas before
azure-pipelines.yml
Outdated
| @@ -79,6 +79,7 @@ steps: | |||
| failOnStderr: true | |||
|
|
|||
| - bash: | | |||
| export source_branch=$(System.PullRequest.SourceBranch) | |||
There was a problem hiding this comment.
I would recommend pass the source_branch as argument to Makefile instead of using environment variable.
There was a problem hiding this comment.
OK. Now the source_branch is passed as argument.
|
Codes are modified according to the comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.