Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #126 #127

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Fix #126 #127

merged 1 commit into from
Oct 15, 2018

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Oct 15, 2018

No description provided.

@lmazuel lmazuel requested a review from zooba October 15, 2018 17:51
@codecov-io
Copy link

codecov-io commented Oct 15, 2018 •
edited
Loading

Codecov Report

Merging #127 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #127      +/-   ##
=========================================
- Coverage   87.72%   87.7%   -0.03%     
=========================================
  Files          25      25              
  Lines        2559    2561       +2     
=========================================
+ Hits         2245    2246       +1     
- Misses        314     315       +1
Impacted Files Coverage Δ
msrest/async_paging.py 96.42% <66.66%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5af083...11a6a97. Read the comment docs.

@lmazuel lmazuel mentioned this pull request Oct 15, 2018
Merged
zooba
zooba approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmazuel lmazuel merged commit e3ba039 into master Oct 15, 2018
@lmazuel lmazuel deleted the fix126 branch October 15, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmazuel @codecov-io @zooba