Improve casing errors #202
Conversation
vladbarosan
commented
Jan 31, 2018
•
vladbarosan
commented
- Fix all linter issues
- add option for case insensitive live validation path matching
|
Waiting on the sway PR to get merged https://github.com/amarzavery/sway/pull/20 |
| @@ -92,6 +92,7 @@ class SpecValidator { | |||
| options.definition = self.specInJson; | |||
| options.jsonRefs = {}; | |||
| options.jsonRefs.relativeBase = self.specDir; | |||
| options.isPathCaseSensitive = self.options.isPathCaseSensitive; | |||
There was a problem hiding this comment.
self.options.isPathCaseSensitive; Please document this option in the constructor documentation of SpecValidator class
vladbarosan
force-pushed
the
improveCasingErrors
branch
from
25d9c63
to
aaa3851
Compare
| 'EQUIVALENT_PATH': 'M6008', | ||
| 'DUPLICATE_PARAMETER': 'M6009', |
There was a problem hiding this comment.
Why did we remove these constants from the mapper?
There was a problem hiding this comment.
@amarzavery because those 2 are duplicates. Not sure if the mapped values are used anywhere with a hard dependency so I didn't adapt the numbers for remaining ones. Let me know if I should
There was a problem hiding this comment.
@vishrutshah - There were some duplicates here. Do you know what is the effect of these error codes in reporting?
There was a problem hiding this comment.
@amarzavery I don't thing right now they are used for anything since we don't have official documentation from them also I don't thing @vishrutshah spends his time on Github anymore :)
package.json
Outdated
| "jshint": "jshint index.js --reporter=jslint", | ||
| "test": "npm -s run-script jshint && mocha -t 100000", | ||
| "jshint": "jshint lib --reporter=jslint", | ||
| "test": "mocha -t 100000", |
There was a problem hiding this comment.
does npm run jshint by itself, now? Previously it did not do that. Hence we had to && the jshint script along with mocha.
There was a problem hiding this comment.
Yup it does not run jshint by itself. https://travis-ci.org/Azure/oav/builds/335452396#L970
So please do the following:
"test": "npm -s run-script jshint && mocha -t 100000",
There was a problem hiding this comment.
@amarzavery left it out because there as still a couple of linter issues which I was not sure to resolve. Let me look if I can get it clean and then I can add it back
There was a problem hiding this comment.
Ah I see. I thought you fixed all of them. No worries, if you cannot fix all of them right now.
There was a problem hiding this comment.
@amarzavery Getting there lets clean it up and keep it like that :)
any idea why we iterate here, doesn't seem we do anything different in each iteration:
oav/lib/xMsExampleExtractor.js
Line 192 in 4459e37
There was a problem hiding this comment.
you wont be able to replace this with a for..of. We are iterating over the responses dictionary in swagger for a given operation to extract examples for every response code
"responses": {
"200": {},
"202": {},
. . .
}
|
please update the version in package.json and also update the changelog. |
