-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing multiple oneOf
s
#263
Conversation
also with this , fixes #234 . |
entity = {} | ||
entity.oneOf = [savedEntity, { type: "null" }] | ||
entity = { | ||
anyOf: [savedEntity, { type: "null" }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyOf [](start = 6, length = 5)
is this the only place where we used to make a oneOf between the type and null ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one that I'm aware of that causes problems. It looks like other cases where we use oneOf
should be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also I was wondering, are we ready to enable tslint on the project
In reply to: 196611051 [](ancestors = 196611051)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vladbarosan tslint is enabled already
"tslint": "tslint ./*.ts ./lib/**/*.ts ./test/**/*.ts ./types/**/*.ts",
"test": "npm run tslint && nyc mocha ./test/**/*.ts -r ts-node/register -t 10000",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue #248