Fixing multiple oneOfs
#263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also with this , fixes #234 . |
vladbarosan
reviewed
Jun 19, 2018
| entity = {} | ||
| entity.oneOf = [savedEntity, { type: "null" }] | ||
| entity = { | ||
| anyOf: [savedEntity, { type: "null" }] |
There was a problem hiding this comment.
anyOf [](start = 6, length = 5)
is this the only place where we used to make a oneOf between the type and null ?
There was a problem hiding this comment.
The one that I'm aware of that causes problems. It looks like other cases where we use oneOf should be good.
There was a problem hiding this comment.
also I was wondering, are we ready to enable tslint on the project
In reply to: 196611051 [](ancestors = 196611051)
There was a problem hiding this comment.
@vladbarosan tslint is enabled already
"tslint": "tslint ./*.ts ./lib/**/*.ts ./test/**/*.ts ./types/**/*.ts",
"test": "npm run tslint && nyc mocha ./test/**/*.ts -r ts-node/register -t 10000",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #248