feat: Add parameter for Managed App subtype #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dciborow
changed the title
|
not ready for review or merge - stilll in progress but putting it up as PR for visability |
|
Ready for review. This adds the subtype parameter, and also fixes a bug. Before making more modifications, think it's time to review and merge these changes. |
kevinhillinger
approved these changes
Mar 22, 2023
partnercenter/azext_partnercenter/operations/marketplace_offer_plan/params.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, edit the PR description and run through the relevant checklist below.
This also fixes an issue when running 'az partnercenter marketplace offer plan update', by first checking if 'externalID' is in variant.
https://github.com/dciborow/partnercenter-cli-extension/blob/dc3a9592f2b853ea5f7c5e69b8e47d0ef47d916d/partnercenter/azext_partnercenter/clients/plan_client.py#L57:L66