Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for attaching Azure Container Registries #119

Closed
hairmare opened this issue Aug 10, 2021 · 1 comment
Closed

Add support for attaching Azure Container Registries #119

hairmare opened this issue Aug 10, 2021 · 1 comment

Comments

@hairmare
Copy link
Contributor

hairmare commented Aug 10, 2021

Hi we would like to attach an ACR isntance to a cluster, both at creation time or as an update as per these docs.

It would be nice if the module would support both these use cases:

  1. Create a new AKS cluster with ACR integration
# set this to the name of your Azure Container Registry.  It must be globally unique
MYACR=myContainerRegistry

# Run the following line to create an Azure Container Registry if you do not already have one
az acr create -n $MYACR -g myContainerRegistryResourceGroup --sku basic

# Create an AKS cluster with ACR integration
az aks create -n myAKSCluster -g myResourceGroup --generate-ssh-keys --attach-acr $MYACR
  1. Configure ACR integration for existing AKS clusters
az aks update -n myAKSCluster -g myResourceGroup --attach-acr <acr-name>

I've recently seen an uptick in ACR usage so this might be something you would want to prioritize. I haven't checked if the terraform provider already supports this.

@lonegunmanb
Copy link
Member

This feature has been implemented by #298 so I'm closing this issue now, please feel free to reopen it if you have any further question, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants