Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for acr attachment #298

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Add support for acr attachment #298

merged 3 commits into from
Feb 10, 2023

Conversation

lonegunmanb
Copy link
Member

@lonegunmanb lonegunmanb commented Feb 9, 2023 •
edited
Loading

Describe your changes

As #119 described if we want to use Aks along with Acr, we must assign ACRPull role to Aks's kube identity. This pull request added support for this feature along with an working example as this document suggested.

Issue number

#119

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests February 9, 2023 13:15 — with GitHub Actions Inactive
@lonegunmanb lonegunmanb temporarily deployed to acctests February 9, 2023 15:34 — with GitHub Actions Inactive
@lonegunmanb lonegunmanb temporarily deployed to acctests February 10, 2023 01:39 — with GitHub Actions Inactive
jiaweitao001
jiaweitao001 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jiaweitao001 jiaweitao001 merged commit 69bcc82 into Azure:main Feb 10, 2023
@lonegunmanb lonegunmanb mentioned this pull request Feb 10, 2023
Closed
@lonegunmanb lonegunmanb deleted the acr-support branch November 21, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaweitao001 jiaweitao001 jiaweitao001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonegunmanb @jiaweitao001