-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export addon_profile attributes #151
Conversation
@lonegunmanb PTAL? |
Hi @davidkarlsen , thanks for your pr! I've just leave a comment on your code, would you please change a little to make the module caller easier to use this output? Thanks! |
Sorry for the late response - didn't notice it. I can't see any comment? Maybe you forgot to submit the review? |
Hi @davidkarlsen , sorry for my fault. Would you please take a look? |
Signed-off-by: David J. M. Karlsen <[email protected]>
@lonegunmanb fixed. Maybe needs some length check and defaulting to null? |
@davidkarlsen Great idea! Should we use |
@lonegunmanb fixed can it be merged and released now? |
@lonegunmanb what about #157 - can it be merged soon too? It's painful to lag so much on the provider version. |
@lonegunmanb ping |
@lonegunmanb can you do a release too? |
@davidkarlsen #133 is nearly complete, can we wait for 1-2 days at most to see whether we can include this pr into our next release too? Thanks for your patience! |
@davidkarlsen 4.16.0 has been released. |
Export the addon_profile attributes in order to make these consumable by other resources.