Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Remove unused net_profile_docker_bridge_cidr #222

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

zioproto
Copy link
Collaborator

Since 2020 the default runtime is containerd and not Docker
https://github.com/Azure/AKS/blob/master/CHANGELOG.md#release-2020-06-29

The setting docker_bridge_cidr is doing nothing.
If you check the interfaces on the AKS nodes they dont have any Docker bridge configured.

Fixes #122

@zioproto
Copy link
Collaborator Author

This can't be removed so easily 😭
from the docs:
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster
Screenshot 2022-07-13 at 12 35 35

@zioproto
Copy link
Collaborator Author

This PR is currently blocked by hashicorp/terraform-provider-azurerm#18119

After the issue in the azurerm provider is closed, it is possible to finish this PR

@lonegunmanb
Copy link
Member

This PR is currently blocked by hashicorp/terraform-provider-azurerm#18119

After the issue in the azurerm provider is closed, it is possible to finish this PR

Removing an argument from Terraform Provider will be considered as a breaking change, so it won't be implemented until 4.0, which I believe will be in next year.

@zioproto
Copy link
Collaborator Author

this PR should work once hashicorp/terraform-provider-azurerm#20952 is released in the provider

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-check.yaml:prepr-check. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-actions
Copy link
Contributor

Potential Breaking Changes in e3e36b4:
[delete] "Variables.net_profile_docker_bridge_cidr.Name" from 'net_profile_docker_bridge_cidr' to ''

@zioproto
Copy link
Collaborator Author

as per hashicorp/terraform-provider-azurerm#18119 the provider change is available in provider version v3.49.0

@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions bot Apr 10, 2023
@lonegunmanb
Copy link
Member

Hi @zioproto, I think it's time to merge this pr in 7.0.0, would you please rebase your branch with the latest main branch and commit again? Thanks!

@lonegunmanb lonegunmanb changed the title Remove unused net_profile_docker_bridge_cidr [Breaking] Remove unused net_profile_docker_bridge_cidr Apr 10, 2023
@lonegunmanb lonegunmanb added this to the 7.0.0 milestone Apr 10, 2023
Since 2020 the default runtime is containerd and not Docker
https://github.com/Azure/AKS/blob/master/CHANGELOG.md#release-2020-06-29

The setting docker_bridge_cidr is doing nothing.
If you check the interfaces on the AKS nodes they dont have any Docker bridge configured.

Related: hashicorp/terraform-provider-azurerm#18119
@github-actions
Copy link
Contributor

Potential Breaking Changes in 383f6e4:
[delete] "Variables.net_profile_docker_bridge_cidr.Name" from 'net_profile_docker_bridge_cidr' to ''

@zioproto zioproto temporarily deployed to acctests April 11, 2023 10:09 — with GitHub Actions Inactive
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zioproto, LGTM! 🚀

@lonegunmanb lonegunmanb merged commit 90532bf into Azure:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why does the example usage use "170.10.0.1/16" for the docker bridge cidr?
2 participants