-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Remove unused net_profile_docker_bridge_cidr #222
Conversation
This can't be removed so easily 😭 |
This PR is currently blocked by hashicorp/terraform-provider-azurerm#18119 After the issue in the azurerm provider is closed, it is possible to finish this PR |
Removing an argument from Terraform Provider will be considered as a breaking change, so it won't be implemented until 4.0, which I believe will be in next year. |
this PR should work once hashicorp/terraform-provider-azurerm#20952 is released in the provider |
7a96814
to
e3e36b4
Compare
You have successfully added a new CodeQL configuration |
Potential Breaking Changes in e3e36b4: |
as per hashicorp/terraform-provider-azurerm#18119 the provider change is available in provider version v3.49.0 |
e3e36b4
to
4f05ce5
Compare
Hi @zioproto, I think it's time to merge this pr in 7.0.0, would you please rebase your branch with the latest main branch and commit again? Thanks! |
Since 2020 the default runtime is containerd and not Docker https://github.com/Azure/AKS/blob/master/CHANGELOG.md#release-2020-06-29 The setting docker_bridge_cidr is doing nothing. If you check the interfaces on the AKS nodes they dont have any Docker bridge configured. Related: hashicorp/terraform-provider-azurerm#18119
4f05ce5
to
383f6e4
Compare
Potential Breaking Changes in 383f6e4: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zioproto, LGTM! 🚀
Since 2020 the default runtime is containerd and not Docker
https://github.com/Azure/AKS/blob/master/CHANGELOG.md#release-2020-06-29
The setting
docker_bridge_cidr
is doing nothing.If you check the interfaces on the AKS nodes they dont have any Docker bridge configured.
Fixes #122