Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark outputs as sensitive #231

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

jvelasquez
Copy link
Contributor

@jvelasquez jvelasquez commented Aug 17, 2022

Using the latest 5.0.0 + terragrunt, I have run into the following errors:

### shortened for clarity 
azurerm_kubernetes_cluster.main: Creation complete after 11m7s [id=/subscriptions/xxxx/resourceGroups/resource-group/providers/Microsoft.ContainerService/managedClusters/yyyy]

│ Error: Output refers to sensitive values
│   on outputs.tf line 11:
│   11: output "admin_client_certificate" {
│   16: output "admin_client_key" {
│   21: output "admin_cluster_ca_certificate" {
│   26: output "admin_host" {
│   31: output "admin_password" {
│   36: output "admin_username" {
 
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│ 
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│     sensitive = true

Fixes #000

Changes proposed in the pull request:

  • adding extra sensitive = true line into the above mentioned outputs to avoid running into this issue

Using the latest 5.0.0 + terragrunt, I have run into the following errors:

```bash
### shortened for clarity 
azurerm_kubernetes_cluster.main: Creation complete after 11m7s [id=/subscriptions/xxxx/resourceGroups/resource-group/providers/Microsoft.ContainerService/managedClusters/yyyy]

│ Error: Output refers to sensitive values
│   on outputs.tf line 11:
│   11: output "admin_client_certificate" {
│   16: output "admin_client_key" {
│   21: output "admin_cluster_ca_certificate" {
│   26: output "admin_host" {
│   31: output "admin_password" {
│   36: output "admin_username" {
 
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│ 
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│     sensitive = true
╵
```
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jvelasquez , LGTM!

@lonegunmanb lonegunmanb merged commit c12d31a into Azure:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants