Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Kubernetes Cluster Name #234

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Output Kubernetes Cluster Name #234

merged 3 commits into from
Aug 31, 2022

Conversation

vermacodes
Copy link
Contributor

Fixes #233

Changes proposed in the pull request:

Output name of the Kubernetes cluster

@ghost
Copy link

ghost commented Aug 24, 2022

CLA assistant check
All CLA requirements met.

vermacodes added a commit to vermacodes/one-click-aks that referenced this pull request Aug 24, 2022
- This change is proposed on the upstrem project and can be enabled only after its merged. PR Azure/terraform-azurerm-aks#234
@vermacodes
Copy link
Contributor Author

Hello @lonegunmanb Any thoughts on this PR?

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM but a tiny change request, thanks for your pr!

outputs.tf Outdated Show resolved Hide resolved
Add '.' in the description of output aks_name
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution @vermacodes !

@lonegunmanb lonegunmanb merged commit f3e30d5 into Azure:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output Kubernetes Name
2 participants