Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for web_app_routing #297

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Add support for web_app_routing #297

merged 1 commit into from
Feb 9, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

This pull request added support for web_app_routing.

Issue number

#296

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests February 8, 2023 13:34 — with GitHub Actions Inactive
rjsigma
rjsigma reviewed Feb 8, 2023
View reviewed changes
Copy link

@rjsigma rjsigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the ask so fast. This looks great.

jiaweitao001
jiaweitao001 approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jiaweitao001 jiaweitao001 merged commit de98a79 into Azure:main Feb 9, 2023
@lonegunmanb lonegunmanb deleted the web_app_routing branch November 21, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjsigma rjsigma rjsigma left review comments

@jiaweitao001 jiaweitao001 jiaweitao001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lonegunmanb @rjsigma @jiaweitao001