Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for default node pool's node_taints #300

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

This pr added support for default_node_pool.node_taints argument.

Issue number

#299

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests February 10, 2023 09:50 — with GitHub Actions Inactive
@mloskot
Copy link

mloskot commented Feb 10, 2023

Shouldn't the default be [] instead of null? See #85

I'm observing the following plan changes (Terraform 1.3.7, hashicorp/azurerm 3.43.0, AKS K8s 1.25.5):

Note: Objects have changed outside of Terraform
    ...
    name                    = "nplin1"
    node_count              = 2
  + node_taints             = []
    tags                    = {
    ...

@lonegunmanb
Copy link
Member Author

Thanks for asking @mloskot, for this argument I've checked the schema definition in AzureRM provider:

"node_taints": {
						Type:     pluginsdk.TypeList,
						ForceNew: true,
						Optional: true,
						Elem: &pluginsdk.Schema{
							Type: pluginsdk.TypeString,
						},
					},

Optional: true means the default value for this argument is null. As for the change you've seen in the plan, you can export the tfplan as json and check whether if there's any action generated for that change, as I've done in our test framework. If there's no action then we don't need to worry about it.

@mloskot
Copy link

mloskot commented Feb 12, 2023

@lonegunmanb Thanks for the explanation and suggestions. I'll try it out.

Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@lonegunmanb lonegunmanb merged commit 6b1187c into Azure:main Feb 13, 2023
@lonegunmanb lonegunmanb deleted the default-node-pool-taints branch November 21, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants