Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade required Terraform version #338

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Upgrade required Terraform version #338

merged 1 commit into from
Mar 28, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

Optional object field was introduced since Terraform 1.3 so we should upgrade the required Terraform version to >= 1.3.

Issue number

#337

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb added this to the 6.8.0 milestone Mar 28, 2023
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-check.yaml:prepr-check. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@lonegunmanb lonegunmanb temporarily deployed to acctests March 28, 2023 04:41 — with GitHub Actions Inactive
jiaweitao001
jiaweitao001 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@jiaweitao001 jiaweitao001 merged commit 851478b into Azure:main Mar 28, 2023
@lonegunmanb lonegunmanb deleted the f-337 branch June 30, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaweitao001 jiaweitao001 jiaweitao001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lonegunmanb @jiaweitao001