fixed inaccurate variable descriptions for azure cni in overlay mode #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Adfinis" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The current description for the variable net_profile_pod_cidr is inaccurate since it states that this field can only be set when network_plugin is set to kubenet, but it can (and probably will) be used with the azure cni in overlay mode.
The variable description for network_plugin_mode states, that the only possible value is 'Overlay', which works, but the API will change it to lowercase 'overlay', terraform will attempt to change this to uppercase 'Overlay' during every subsequent apply, according to my testing.
Issue number
#000
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!