Add private option for loadbalancer

[jmapro]

module "mylb" {
  source                                  = "Azure/loadbalancer/azurerm"
  type                                    = "private"
  frontend_subnet_id                      = "MySubnetID"
  frontend_private_ip_address_allocation  = "Static"
  frontend_private_ip_address             = "MyAddressIP"
  
  ...

Default type = public
Default frontend_private_ip_address_allocation = "Dynamic"

[jmapro]

Hello @dcaro @dtzar ,

Is it possible to have a review please ?

Thanks.

[dcaro]

@lbnjma I was oof last week, looking at it now.

[dtzar]

@lbnjma Sorry for the extremely long delay in reviewing this one! Per @dcaro above comment, I thought he had it. I didn't test it, but it looks good to me.

[dtzar]

@jeffreyCline Can you check to make sure the examples work and that someone can provision a load balancer without a private option?
@lbnjma - can you please do a rake format to fix the styling? See: https://github.com/Azure/terraform-test

[WodansSon]

@lbnjma Since you are adding new options to the module this needs to be reflected in the README.md file. Can you document the changes and add sample usage cases?

[jmapro]

@dtzar Thanks for the review, I've fixed the styling
@jeffreyCline I've updated the documentation, let me know if something is wrong.

[WodansSon]

@lbnjma It looks like my changes have conflicted with your update to the readme file. Can you resolve the conflicts?

[dtzar]

I resolved the merge conflict and made some updates to the readme. I also tested this out with the vmss-cloudinit module for public IP and it worked.