-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add private option for loadbalancer #3
Conversation
@lbnjma I was oof last week, looking at it now. |
@lbnjma Sorry for the extremely long delay in reviewing this one! Per @dcaro above comment, I thought he had it. I didn't test it, but it looks good to me. |
@jeffreyCline Can you check to make sure the examples work and that someone can provision a load balancer without a private option? |
@lbnjma Since you are adding new options to the module this needs to be reflected in the README.md file. Can you document the changes and add sample usage cases? |
@dtzar Thanks for the review, I've fixed the styling |
@lbnjma It looks like my changes have conflicted with your update to the readme file. Can you resolve the conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resolved the merge conflict and made some updates to the readme. I also tested this out with the vmss-cloudinit module for public IP and it worked.
Default
type = public
Default
frontend_private_ip_address_allocation = "Dynamic"