-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ddos_protection_plan configuration to vnet #66
add ddos_protection_plan configuration to vnet #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging @lonegunmanb to ask for review (who reviewed last several PRs).
@jeongkyeong: would you describe how it would be applicable by specifying use case(s) you are on mind?
Note that I am not an authorized reviewer regarding your PR but hope it helps.
Added one of the features of vnet, which allows you to set up a ddos protection plan. And this feature is also officially supported by Terraform. This is a use case in terraform code(which is also being used as a module) using the azure vnet module.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Modify vnet's ddos protection plan to be configurable.
The default value is 'null', so set it only when it is necessary.
Input variable example
Fixes #000
Changes proposed in the pull request: