Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore polling error from nonstandard LRO APIs #341

Merged
merged 2 commits into from
Aug 17, 2023
Merged

ignore polling error from nonstandard LRO APIs #341

merged 2 commits into from
Aug 17, 2023

Conversation

ms-henglu
Copy link
Member

@ms-henglu ms-henglu commented Aug 17, 2023 •
edited
Loading

fixes #271, #184

@ms-henglu ms-henglu mentioned this pull request Aug 17, 2023
Closed
@ms-henglu ms-henglu requested a review from magodo August 17, 2023 08:09
@ms-henglu ms-henglu mentioned this pull request Aug 17, 2023
Closed
magodo
magodo reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both cases look tricky to me, for both cases, I'd prefer we introduce a new toggle to bypass polling, which looks more sensible?

@ms-henglu ms-henglu requested a review from magodo August 17, 2023 08:43
@ms-henglu ms-henglu merged commit 19e4772 into main Aug 17, 2023
10 checks passed
@ms-henglu ms-henglu deleted the issue-337 branch August 17, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magodo magodo magodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed GET before PUT for azapi_resource_action
2 participants
@ms-henglu @magodo