Skip to content

Commit

Permalink
[tcgc] rename UsageFlags.Versioning -> UsageFlags.ApiVersionEnum (#501)
Browse files Browse the repository at this point in the history
  • Loading branch information
iscai-msft authored Mar 22, 2024
1 parent 4ca8ad6 commit 1bd2081
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
7 changes: 7 additions & 0 deletions .chronus/changes/versioning_enum-2024-2-22-14-26-15.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@azure-tools/typespec-client-generator-core"
---

rename UsageFlags.Versioning to UsageFlags.ApiVersionEnum
2 changes: 1 addition & 1 deletion packages/typespec-client-generator-core/src/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -534,5 +534,5 @@ export enum UsageFlags {
None = 0,
Input = 1 << 1,
Output = 1 << 2,
Versioning = 1 << 3,
ApiVersionEnum = 1 << 3,
}
2 changes: 1 addition & 1 deletion packages/typespec-client-generator-core/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1533,7 +1533,7 @@ export function getAllModelsWithDiagnostics(
if (versionMap && versionMap.getVersions()[0]) {
// create sdk enum for versions enum
const sdkVersionsEnum = getSdkEnum(context, versionMap.getVersions()[0].enumMember.enum);
updateUsageOfModel(context, UsageFlags.Versioning, sdkVersionsEnum);
updateUsageOfModel(context, UsageFlags.ApiVersionEnum, sdkVersionsEnum);
}
}
// update access
Expand Down
4 changes: 2 additions & 2 deletions packages/typespec-client-generator-core/test/types.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ describe("typespec-client-generator-core: types", () => {
strictEqual(sdkType.isFixed, true);
strictEqual(sdkType.name, "DaysOfWeekExtensibleEnum");
strictEqual(sdkType.valueType.kind, "string");
strictEqual(sdkType.usage & UsageFlags.Versioning, 0); // not a versioning enum
strictEqual(sdkType.usage & UsageFlags.ApiVersionEnum, 0); // not a versioning enum
const values = sdkType.values;
strictEqual(values.length, 7);
const nameList = [
Expand Down Expand Up @@ -1218,7 +1218,7 @@ describe("typespec-client-generator-core: types", () => {
const enums = runner.context.experimental_sdkPackage.enums;
strictEqual(enums.length, 1);
strictEqual(enums[0].name, "Versions");
strictEqual(enums[0].usage, UsageFlags.Versioning);
strictEqual(enums[0].usage, UsageFlags.ApiVersionEnum);
});
});

Expand Down

0 comments on commit 1bd2081

Please sign in to comment.