Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tcgc] roll back change we made that allowed any union of values to be an extensible enum #385

Closed
iscai-msft opened this issue Mar 7, 2024 · 1 comment · Fixed by #389
Assignees
Labels
bug Something isn't working

Comments

@iscai-msft
Copy link
Contributor

In the last release, we decided to always generate a union of constants as an enum. However, after talking more with @lmazuel and seeing the confusion here, we've decided to only generate an enum from a union if the union is named

@tadelesh
Copy link
Member

tadelesh commented Mar 8, 2024

The root cause is not the anonymous, It is from the hierarchy. My fix will rollback the change for hierarchy. Details could be found in my PR's tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants