-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add union and enum doc and refine logic #389
Conversation
All changed packages have been documented. |
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/389/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/389/ |
@iscai-msft I saw you rollbacked my change for union as enum with hierarchy. I'm wondering do we have the agreement of erasing the hierarchy types and flattened into one layer of enum? It will break JS RLC, since the type has been changed. For the following example, I don't think we could omit
|
here's the gist I wrote up https://gist.github.com/iscai-msft/4174b2e13811c13d91af86c1296e9ed1 |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
…ix_union_enum_hierarchy
fix: #379
resolve: #385