Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing-x-ms-identifier rule not checking base class for properties #1537

Merged

Conversation

timotheeguerin
Copy link
Member

fix #1358

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library label Sep 13, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 13, 2024

All changed packages have been documented.

  • @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - fix ✏️

Fix missing-x-ms-identifier rule not checking base class for properties

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@timotheeguerin timotheeguerin added this pull request to the merge queue Oct 2, 2024
Merged via the queue into Azure:main with commit f984827 Oct 2, 2024
22 checks passed
@timotheeguerin timotheeguerin deleted the fix/x-ms-identifier-inheritance branch October 2, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: missing-x-ms-identifiers rule produces false positives on 'extends' properties
3 participants